Page MenuHomeElementl

[Draft] [RFC] [dagster-graphql] Initial Python Client implementation
AbandonedPublic

Authored by sidkmenon on Wed, Apr 7, 6:05 PM.

Details

Reviewers
None
Summary
Still a lot to do:

1. Adding error handling logic (propagating errors up from GraphQL response)
2.  Add better descriptions/doc strings to the DagsterGraphQLClient & associated functions 
3. Avoid requiring specifying repository location name and repository name for `submit_pipeline_execution`
  a. Solution would involve a second query to grab the repo location name & repository name
4. Testing
  a. Includes versioning / back-compatibility scaffolding 
5. Async & options other than HTTP
  a. Could potentially be solved by using a client library like [gql](https://github.com/graphql-python/gql)
Test Plan

TODO

Diff Detail

Repository
R1 dagster
Branch
python-client (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

sidkmenon created this revision.

small change on line 82 for clarity

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Apr 7, 6:42 PM
Harbormaster failed remote builds in B28549: Diff 35038!
sidkmenon retitled this revision from [RFC] [dagster-graphql] Initial Python Client implementation to [Draft] [RFC] [dagster-graphql] Initial Python Client implementation.Wed, Apr 7, 9:18 PM
sidkmenon removed a reviewer: rexledesma.