Page MenuHomeElementl

Use Jinja templating
ClosedPublic

Authored by max on Apr 6 2021, 10:21 PM.

Details

Summary

Don't use string .replace(); this is more extensible when we want to add other stuff into the templating environment.

Test Plan

Manually confirmed that templating of app prefix worked in Graphiql and index views.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 6 2021, 10:40 PM
Harbormaster failed remote builds in B28522: Diff 35003!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2021, 11:27 PM
Harbormaster failed remote builds in B28570: Diff 35066!

reinstate replacement for static src paths

python_modules/dagit/dagit/app.py
199

@dish how bout this

also replace href="/static

max requested review of this revision.Apr 8 2021, 6:52 PM
This revision is now accepted and ready to land.Apr 8 2021, 7:11 PM
This revision was automatically updated to reflect the committed changes.