Page MenuHomeElementl

Make more dagster grpc server parameters controllable via env var
ClosedPublic

Authored by dgibson on Apr 6 2021, 3:38 PM.

Details

Summary

This is useful when dagster is managing gRPC servers defined in Dockerfiles - we can configure them by setting env vars on the container rather than requiring a certain command or entrypoint.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann requested changes to this revision.Apr 6 2021, 4:11 PM

Just realized this is a click feature, should we use this instead? https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables

This revision now requires changes to proceed.Apr 6 2021, 4:11 PM

++ use the click thing

This revision is now accepted and ready to land.Apr 6 2021, 8:08 PM