Page MenuHomeElementl

add bulk actions to asset view, for asset wipe
ClosedPublic

Authored by prha on Apr 5 2021, 10:41 PM.

Details

Summary

not sure about the spacing.

Updated (w/ button instead of dropdown):

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha requested review of this revision.Apr 5 2021, 11:01 PM
dish requested changes to this revision.Apr 6 2021, 2:11 PM

We'll need to come up with a solution on the spacing, and I'm very curious about "wipe" vs. "delete".

js_modules/dagit/packages/core/src/assets/AssetWipeDialog.tsx
43

Why do we use the term "wipe" for assets, but not for other objects? Is there a difference between "wiping" an asset as opposed to "deleting" an asset?

js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx
286

Is this copied from RunTable? If so, it should be factored out into a shared hook. I can do this in a followup.

405

Yeah, the spacing looks broken.

If you were to combine the checkbox and asset key link in a single cell, would people understand that the text is the asset key, or is the header very important?

Alternatively, perhaps the menu (or button) can be moved somewhere that it doesn't interfere with the table headers.

517

Are you planning to add more actions to this menu? If not, can it just be a button?

This revision now requires changes to proceed.Apr 6 2021, 2:11 PM
js_modules/dagit/packages/core/src/assets/AssetWipeDialog.tsx
43

I think it might be misleading to say delete. Assets are kind of a synthetic construct built upon the immutable event log. We can mark them as "wiped" as of a certain timestamp, and then we hide earlier materializations for that asset key from the asset catalog, but the materializations will still exist in the original run view.

Also, we kind of use wipe interchangeably (e.g. dagster run wipe CLI command).

js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx
286

yes, copied.

517

I think it can be a button... maybe just a small trash can button?

  • switch to button from selector
This revision is now accepted and ready to land.Apr 9 2021, 3:49 PM
This revision was automatically updated to reflect the committed changes.