Page MenuHomeElementl

Add docker image run tag in k8s launchers
ClosedPublic

Authored by johann on Apr 2 2021, 11:52 PM.

Details

Summary

The k8s launchers have been slacking compared to their more informative Docker launcher cousin.

Potential oddity in the future if we ever support multi-container pipelines. But cross that bridge then?

note- will break internal docker integration test, due to tag rename

Test Plan

Integration

and unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann retitled this revision from Add image tag to k8s launchers to Add docker image run tag in k8s launchers.Apr 2 2021, 11:54 PM
johann edited the summary of this revision. (Show Details)
johann edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 3 2021, 12:40 AM
Harbormaster failed remote builds in B28413: Diff 34869!
Harbormaster failed remote builds in B28414: Diff 34870!
johann requested review of this revision.Apr 3 2021, 1:05 AM

nice

integration_tests/test_suites/celery-k8s-integration-test-suite/test_integration.py
80

use the dagster_docker_image fixture you already have instead of re-calling get_test_project_docker_image?

This revision is now accepted and ready to land.Apr 6 2021, 1:40 PM
This revision was automatically updated to reflect the committed changes.