Page MenuHomeElementl

[dynamic] fix multiple collects on one step
ClosedPublic

Authored by alangenfeld on Apr 2 2021, 9:43 PM.

Details

Summary

This allows for having a solid collect on two different dynamic outputs.

To do this we change resolvable_map to key on a set of step keys that must be complete instead of just one.

This makes a small step towards supporting being downstream of multiple multiple outputs, but there is still quite a bit of work to make that happen.

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2021, 10:01 PM
Harbormaster failed remote builds in B28406: Diff 34860!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 5 2021, 3:14 PM
Harbormaster failed remote builds in B28431: Diff 34888!
dgibson added inline comments.
python_modules/dagster/dagster/core/definitions/dependency.py
658–659

nit: missing of

python_modules/dagster/dagster/core/execution/plan/plan.py
851

nit whose

This revision is now accepted and ready to land.Apr 6 2021, 12:47 AM