Page MenuHomeElementl

[dagit] RFC: Simplify GraphQL Playground usage
ClosedPublic

Authored by dish on Apr 2 2021, 7:04 PM.

Details

Summary

We currently require graphql-playground-react in dagit/core, but only to grab its static assets from node_modules and jam them into a vendor directory to be referenced in playground.py.

Instead, check in the static assets and just cp them to the target vendor directory during the build-for-python step.

Open to discussion on this.

Test Plan

Run dagit, navigate to /graphql locally. Verify that the GraphQL playground loads and behaves correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2021, 7:23 PM
Harbormaster failed remote builds in B28395: Diff 34845!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2021, 7:47 PM
Harbormaster failed remote builds in B28399: Diff 34852!
dish requested review of this revision.Apr 5 2021, 1:37 PM

You know, I think I remember when we started doing this a long while back, and it was so that the Dagit graphql playground would work totally offline. (https://github.com/dagster-io/dagster/commit/7376c95cecc2a02f74dc213b533be187ea45b221) I don't know that it turned out to be as important as we thought it might, so I'm a fan of this change.

This revision is now accepted and ready to land.Apr 7 2021, 3:17 PM

Check in graphql-playground-react assets instead of using CDN.

dish requested review of this revision.Apr 7 2021, 6:51 PM
dish added a reviewer: max.
dish edited the summary of this revision. (Show Details)
dish edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 7 2021, 11:06 PM
This revision was landed with ongoing or failed builds.Apr 8 2021, 1:19 AM
This revision was automatically updated to reflect the committed changes.