Page MenuHomeElementl

[dagit] Make sure repoAddress is used for Pipeline definition
ClosedPublic

Authored by dish on Mar 31 2021, 10:23 PM.

Details

Summary

A handful of places in Dagit aren't taking the repoPath URL params into account, leading to problems when there are colliding pipeline, solid, schedule, or sensor names.

  • Fix left nav selection state
  • Fix pipeline definition and solid navigation
Test Plan

Patch https://dagster.phacility.com/D7247. Verify that left nav highlight states, pipeline definition maps, and solid navigation are all working properly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Mar 31 2021, 10:33 PM

thanks!

js_modules/dagit/packages/core/src/nav/RepositoryContentList.tsx
99

this 'repoName@repolocationName' pattern could go in a helper function potentially?

This revision is now accepted and ready to land.Apr 1 2021, 2:17 PM