Page MenuHomeElementl

[dagit] Upgrade to React 17
ClosedPublic

Authored by dish on Mar 31 2021, 6:59 PM.

Details

Summary

Upgrade Dagit to React 17. This can wait til after the Thursday release.

I fixed a bug that showed up in the logs scrolling table on the Run page, but otherwise I didn't spot any issues. In a followup, I'll clean up peer dependencies mismatches where I can.

Test Plan

Buildkite, load Dagit and click everywhere. Verify that things seem okay.

Diff Detail

Repository
R1 dagster
Branch
dish-react-17
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

dish requested review of this revision.Mar 31 2021, 7:08 PM

Whoa nice! I guess we were mostly on function components already so a lot of the class component deprecations didn't matter - that's awesome!

This revision is now accepted and ready to land.Apr 1 2021, 3:42 AM

Rebase to sanity check BK

This revision was automatically updated to reflect the committed changes.