Page MenuHomeElementl

More @core peer-deps, new top nav exported from core
ClosedPublic

Authored by bengotow on Mar 30 2021, 9:41 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2021, 9:50 PM
Harbormaster failed remote builds in B28258: Diff 34657!

Looks like there's a lint error, otherwise this looks good to me! Happy to stamp it once it's past BK.

js_modules/dagit/packages/core/src/search/SearchDialog.tsx
144–145

I feel like this would look nice next to the placeholder now, otherwise it's too far to the right and easy to miss.

  • Fix linter error, move slash shortcut closer to the placholder text
This revision is now accepted and ready to land.Mar 30 2021, 10:45 PM