Page MenuHomeElementl

[dagit] Add id to Asset
ClosedPublic

Authored by dish on Mar 30 2021, 8:36 PM.

Details

Summary

Give the Asset type an id field to avoid Apollo cache issues. Not sure this is the most ideal ID value here (e.g. AssetKey(['table_info'])), so let me know if I should change it.

Test Plan

Buildkite, load Dagit and sanity check global search behavior and Assets page behavior.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2021, 8:55 PM
Harbormaster failed remote builds in B28252: Diff 34647!
dish requested review of this revision.Mar 30 2021, 9:19 PM
This revision is now accepted and ready to land.Mar 30 2021, 9:37 PM
This revision was automatically updated to reflect the committed changes.