Fixes https://github.com/dagster-io/dagster/issues/1617, with a potential hit to render performance. See: https://github.com/bvaughn/react-virtualized/blob/master/docs/CellMeasurer.md#prop-types-1
Details
Details
- Reviewers
schrockn bengotow - Group Reviewers
Restricted Project - Commits
- R1:b568e44bed11: Don't use a custom keyMapper
Manual
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
The opposite, I think this might make table render performance worse; I haven't measured.
Comment Actions
Looks good to me! I think since we're blowing away and re-creating the cache now when the node set changes, we don't need the custom key mapping (you're correct that it was allowing you to filter the list without recomputing the height of the rows).