Page MenuHomePhabricator

[dagit] metadata display improvements
ClosedPublic

Authored by alangenfeld on Jul 26 2019, 10:31 PM.

Details

Reviewers
bengotow
schrockn
Group Reviewers
Restricted Project
Commits
R1:4d01d8eac29f: [dagit] metadata display improvements
Test Plan
  • dont gate metadata on a description - create a seperate metadata section
  • add button for generic handler

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jul 26 2019, 10:31 PM
alangenfeld added inline comments.Jul 26 2019, 10:31 PM
js_modules/dagit/src/plugins/index.ts
10

do we prefer this or should we do snowflake as kind=sql

What's the argument to have snowflake-specific metadata versus just plain ole' sql?

might be nice to visually distinguish SQL dialects, e.g. in case you have a mixture of Spark SQL and Snowflake SQL or Hive SQL + Presto SQL

should we key off _sql suffix ?

schrockn accepted this revision.Jul 26 2019, 10:35 PM

I'm relatively indifferent, but generally I think we should only add a special metadata field only if there is actually divergent behavior on the client. However I do not feel strongly about this.

This revision is now accepted and ready to land.Jul 26 2019, 10:35 PM

eh "_sql" suffix is pretty sketch IMO

Did not connect this to an improved metadata viewing experience in dagit. Totally in support

suffix bullshit

walkback suffix noise

schrockn accepted this revision.Jul 26 2019, 10:50 PM

๐Ÿ‘๐Ÿป

This revision was automatically updated to reflect the committed changes.