Page MenuHomeElementl

add compute log manager api to more directly expose file-like object
AbandonedPublic

Authored by prha on Mar 26 2021, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 21, 2:44 PM
Unknown Object (File)
Tue, Jan 10, 7:38 AM
Unknown Object (File)
Dec 21 2022, 1:02 PM
Unknown Object (File)
Nov 24 2022, 10:26 PM
Unknown Object (File)
Nov 19 2022, 9:17 AM
Unknown Object (File)
Nov 17 2022, 10:11 PM
Unknown Object (File)
Nov 17 2022, 10:11 PM
Unknown Object (File)
Nov 17 2022, 10:11 PM
Subscribers
None

Details

Summary

In follow-up diff, might want to remove the read_logs_file method on the compute log
manager in favor of these simpler file-like APIs (may require separate API for binary vs text).

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
prha/compute_log
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

what was the motivation for this?

probably worth having tests for the 3 integrations

This revision now requires changes to proceed.Mar 26 2021, 6:11 PM

k ill let @max sign off since he wrote that issue

python_modules/dagster/dagster/core/instance/__init__.py
522

hi

1559

^

thank you, this is great

This revision is now accepted and ready to land.May 26 2021, 11:06 PM

going to abandon in favor of a new ProcessLogManager API or something similar.