Page MenuHomeElementl

fix should_skip_step
ClosedPublic

Authored by yuhan on Mar 25 2021, 2:22 AM.

Details

Summary

should_skip_step currently returns True when there's no missing source handles

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuhan requested review of this revision.Mar 25 2021, 2:42 AM
This revision is now accepted and ready to land.Mar 25 2021, 5:16 PM
python_modules/dagster/dagster_tests/core_tests/execution_plan_tests/test_execution_plan.py
493

nit: give useful name

up

python_modules/dagster/dagster_tests/core_tests/execution_plan_tests/test_execution_plan.py
493

ooo thx for catching! not a nit at all

This revision was automatically updated to reflect the committed changes.