Page MenuHomeElementl

Roll user deployments if Helm values change
ClosedPublic

Authored by rexledesma on Mar 24 2021, 5:26 PM.

Details

Summary

Resolves https://github.com/dagster-io/dagster/issues/3903.

The user deployment should redeploy if its dependent configmap changes.
However, currently it will not do this since the deployment template
will not have changed even if the configmap changes.

To force the deployment to update, we reason that the deployment should
change if its Helm values have changed.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Branch
rl/update-user-deployments-configmap (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 24 2021, 5:45 PM
Harbormaster failed remote builds in B27962: Diff 34261!

Yay tests!

helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml
25

Is it better to do this on the raw yaml spec than just the configmap?

This revision is now accepted and ready to land.Mar 25 2021, 8:25 PM

looks good! can we run the integration tests too?