Page MenuHomeElementl

Don't throw when two simultaneous alembic stamps result in a unique key violation
AbandonedPublic

Authored by dgibson on Mar 24 2021, 4:50 PM.

Details

Reviewers
prha
alangenfeld
Summary

https://buildkite.com/dagster/dagster-integration-tests/builds/1822#99fa9bd7-7755-46a1-bfcc-3fb61cd41063 points to an issue where two processes both tried to initialize a DB at the same time, which (I think?) should be harmless, so catch an integrity error and just warn instead.

Test Plan

Pretty difficult to specifically test this codepath, but BK covers that the common case is unaffected

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D7123
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 24 2021, 5:11 PM
Harbormaster failed remote builds in B27957: Diff 34256!

test failures appear to be flakes

alangenfeld added inline comments.
python_modules/dagster/dagster/core/storage/sql.py
50–56

can we do a weak substring match just to make sure we don't accidentally eat other types of integrity errors?

This revision is now accepted and ready to land.Mar 24 2021, 8:00 PM

bringing this back since i think its causing daemon integration test failures

This revision is now accepted and ready to land.Tue, Apr 27, 1:42 AM