Page MenuHomeElementl

Add check-manifest tests for package contents
ClosedPublic

Authored by prha on Mar 23 2021, 8:50 PM.

Details

Summary

This adds a test to our buildkite suite called 'manifest' that installs check-manifest and runs it against every library package.

This diff removes some empty requirements.txt files, but otherwise does not change the package contents in sdist.

Instead it configures setup.cfg to instruct check-manifest to ignore certain files that are not included. We should potentially reconsider and start including test files and examples in the manifest, but that should probably be a separate diff.

This would have caught the manifest bug fixed by 4d1cec096.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha requested review of this revision.Mar 23 2021, 9:09 PM

update, check all manifests

prha added reviewers: dgibson, alangenfeld.

include dagster/dagit/dagster-graphql, add COPYING and .md files to the manifest

sweet!

Makefile
46

maybe check_manifest vs manifest?

This revision is now accepted and ready to land.Mar 24 2021, 2:27 PM
This revision was automatically updated to reflect the committed changes.