Page MenuHomeElementl

[docs] bottom nav
ClosedPublic

Authored by yuhan on Mar 23 2021, 8:15 PM.

Details

Summary

moving the bottom prev/next underneath the main text

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuhan published this revision for review.Mar 23 2021, 8:18 PM
yuhan edited the test plan for this revision. (Show Details)
sashank added inline comments.
docs/next/layouts/MainLayout.tsx
568

Super nit: the Pagination component already has a mt-12, so I would just combine these two make the top margin on the pagination mt-20

This revision is now accepted and ready to land.Mar 23 2021, 8:24 PM
docs/next/layouts/MainLayout.tsx
568

i took out the mb-12 from the Pagination, but it still has a mt-12 which i think we need the top margin.

the mb-8 here is for the api docs pages - this diff gets rid of the Pagination on those pages (so they wont have a bottom margin), so i moved the bottom margin on the main body here.

This revision was automatically updated to reflect the committed changes.