Page MenuHomeElementl

[graphql] handle float NaN metadata entry
ClosedPublic

Authored by alangenfeld on Mar 23 2021, 3:53 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 23 2021, 4:14 PM
Harbormaster failed remote builds in B27921: Diff 34200!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 23 2021, 7:00 PM
Harbormaster failed remote builds in B27928: Diff 34216!
sashank added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/events.py
74โ€“76

ย ๐Ÿ‘

84

Do we not need the same isnan check here?

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py
639

Similarly, should we have a test case for:

EventMetadataEntry.int(int("nan"), "int NaN"),
This revision is now accepted and ready to land.Mar 23 2021, 7:33 PM
python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py
639

Or actually, since int("nan") is not possible, just using float("nan") again?

NaN is just a floating point thing

This revision was automatically updated to reflect the committed changes.