Page MenuHomeElementl

[dagit] Back to relative paths
ClosedPublic

Authored by dish on Mar 19 2021, 10:33 PM.

Details

Summary

It'll be a lot easier to deal with builds by switching our import paths back to relative instead of aliased. Since everyone probably has automatic imports set up in VSCode anyway, the drawbacks of relative paths are mitigated.

Test Plan

Load dagit to sanity check. Buildkite.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 19 2021, 10:42 PM
Harbormaster failed remote builds in B27833: Diff 34088!
dish requested review of this revision.Mar 19 2021, 11:56 PM

why is it easier?

I kind of like the aliased paths...

I kind of like the aliased paths...

I did too.

This revision is now accepted and ready to land.Mar 20 2021, 4:14 PM

Also curious about why builds are easier with relative paths

This revision was automatically updated to reflect the committed changes.