Page MenuHomeElementl

Update helm release cli to take chart path
ClosedPublic

Authored by rexledesma on Mar 19 2021, 5:10 PM.

Details

Summary

To do a helm release of the subchart, we need to specify the chart
path. currently it was hard coded to dagster.

Test Plan

local

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

python_modules/automation/automation/release/cli.py
250

what does the corresponding change to the release docs look like? do we need to run this cli command twice in the release process, once for parent chart and once for child?

267

what is --merge index.yaml for?

python_modules/automation/automation/release/cli.py
250

yes - added the new commands to the release guide. Basically, you run this command on the parent chart path, and then the subchart path.

267

just a flag to show that we're explicitly updating the existing index.yaml file for the Helm repo

johann added inline comments.
python_modules/automation/automation/release/cli.py
250

Could add this as description on the click option

This revision is now accepted and ready to land.Mar 23 2021, 5:53 PM