Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
shouldn't there be a package.json change as well?
| js_modules/dagit/src/runs/RunHistory.tsx | ||
|---|---|---|
| 103 | maybe throw instead of taking random default? | |
| js_modules/dagit/src/runs/RunHistory.tsx | ||
|---|---|---|
| 103 | maybe, and this would certainly be a programming error if we got here, but this is still a reasonable default | |
Comment Actions
oh - I thought this was from @sashank, we talked about getting these lint errors to show in editor by yarn add -D eslint-config-react-app + adding "react-app" to the extends key in .eslintrc.js
optional for you to do
Comment Actions
Looks good! Thanks for making all these fixes.
| js_modules/dagit/src/runs/RunHistory.tsx | ||
|---|---|---|
| 103 | Hey! The best thing to do here would be to assertUnreachable(sortType) (It's a helper we added to Utils.) That uses Typescript's narrowing scopes feature to verify that by the time we reach this line the type of sortType is never, indicating that the switch is exhaustive! | |