Page MenuHomeElementl

[docs] dagit screenshots
ClosedPublic

Authored by yuhan on Mar 17 2021, 11:48 PM.

Details

Summary

update dagit screenshots with go/prod - i changed some info a bit like people's emails on the pipeline description :)
also added sensors and re-execution
got rid of "single schedule" because we dont have anything presentable atm

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuhan published this revision for review.Mar 17 2021, 11:55 PM
yuhan edited the test plan for this revision. (Show Details)

The tables in the screenshots look like they're missing the row borders. Is that a rendering bug in Phabricator, or are they missing in the screenshots themselves?

docs/content/concepts/dagit/dagit.mdx
32

Nit: this isn't really a separate page, just a specific view of the definition tab.

got rid of "single schedule" because we dont have anything presentable atm

Hmm, why not? It shows details for a single schedule, its runs, etc -- is that not useful to include here?

would be worth showing the backfill uis here too

would be worth showing the backfill uis here too

@sashank i dont see it on go/prod - maybe it has not been landed yet (?) i'll check it out tomorrow morning again.

The tables in the screenshots look like they're missing the row borders. Is that a rendering bug in Phabricator, or are they missing in the screenshots themselves?

@dish it's the screenshots themselves. i used safari bc of its cleaner window style. seems like the table views don't have borders on safari. do you think i should switch to chrome for the screenshots on this page?

Hmm, why not? It shows details for a single schedule, its runs, etc -- is that not useful to include here?

@dish it's useful to include but go/prod or go/dev doesn't have a good single schedule page to show off the features.. they all look empty :/ , like:

Screen Shot 2021-03-17 at 6.27.45 PM.png (2×3 px, 1 MB)

im not sure if we want an empty page - so i only mention the single page in text without showing a screenshot, see [1]

docs/content/concepts/dagit/dagit.mdx
97

[1]

use chrome because the table css on safari is a bit off

This revision is now accepted and ready to land.Mar 18 2021, 4:57 AM
This revision was automatically updated to reflect the committed changes.