Page MenuHomeElementl

[dagit] Remove custom fonts
ClosedPublic

Authored by dish on Mar 16 2021, 9:31 PM.

Details

Summary

Resolves #3777.

We don't really need our custom web fonts at this point, and they break aggressively in the --path-prefix case.

  • We don't really use Open Sans at all now for normal text, in favor of using system fonts.
  • For monospace, it's fine to just use system fonts as well. Safari uses SF Mono, which is great. Other browsers can fall back to system fonts as needed. I put Source Code Pro on the list before Menlo because it still looks better than Menlo, but honestly Menlo is fine too.
Test Plan

yarn build-for-python in Dagit directory, run dagit with a path prefix. Verify that monospace fonts render properly without falling back to anything terrible (Courier).

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Mar 16 2021, 9:39 PM
This revision is now accepted and ready to land.Mar 17 2021, 4:48 PM
This revision was automatically updated to reflect the committed changes.