Page MenuHomePhabricator

Format duration in step_success message to be human readable
ClosedPublic

Authored by sashank on Jul 25 2019, 5:07 PM.

Details

Summary

In the step_success message, instead of displaying just milliseconds, display a human readable duration string such as 533ms, 2.1s, 4m52s, 34m12s, 1h4m

Test Plan

pytest -k test_format_duration

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Jul 25 2019, 5:07 PM
sashank edited the summary of this revision. (Show Details)Jul 25 2019, 5:08 PM
sashank edited the test plan for this revision. (Show Details)
schrockn accepted this revision.Jul 25 2019, 5:42 PM
schrockn added a subscriber: schrockn.

๐Ÿ‘๐Ÿป

This revision is now accepted and ready to land.Jul 25 2019, 5:42 PM