Page MenuHomeElementl

add ui for instance backfill table
ClosedPublic

Authored by prha on Mar 16 2021, 5:36 PM.

Details

Summary

Test Plan

bk, clicked around, scheduled / canceled backfill

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2021, 5:44 PM
Harbormaster failed remote builds in B27496: Diff 33625!
prha requested review of this revision.Mar 17 2021, 2:27 AM

The UI looks great to me. Deferring to others on the implementation.

This looks sweet to me. @dish did you want to weigh in on the tsx before we ship today?

dish added inline comments.
js_modules/dagit/src/instance/BackfillTerminationDialog.tsx
28โ€“29

Combine

41

x

51

Only one child, Group not necessary

js_modules/dagit/src/instance/InstanceBackfills.tsx
117โ€“118

Combine

This revision is now accepted and ready to land.Mar 18 2021, 4:37 PM
This revision was automatically updated to reflect the committed changes.