Page MenuHomeElementl

Collect support in annotations on the DAG and solid sidebar
ClosedPublic

Authored by bengotow on Mar 15 2021, 9:36 PM.

Details

Summary

This diff adds a new annotation to the DAG viz and updates the solid sidebar to support the new "dynamic collect" feature and also fixes two small logic bugs:

  • Re-executing an entire pipeline does not pass steps_to_execute and was failing
  • UNRESOLVED_COLLECT steps do not need to be expanded because there's just one (run view crash)

image.png (783×670 px, 43 KB)

image.png (910×1 px, 291 KB)

image.png (910×1 px, 304 KB)

Test Plan

Run tests, look at screenshots

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 15 2021, 9:54 PM
Harbormaster failed remote builds in B27422: Diff 33533!

not perfect but better than nothing

This revision is now accepted and ready to land.Mar 17 2021, 6:41 PM

image.png (1×1 px, 108 KB)

Per discussion with @alangenfeld, this now looks a bit nicer and has a color coding to help users understand that the iconography and the layering are related.