Page MenuHomeElementl

Update user deployment subchart schema
ClosedPublic

Authored by rexledesma on Mar 11 2021, 3:14 AM.

Details

Summary

Depends on D6507.

Just some restructuring of the files that generate the
json schema for the Helm charts. Each chart now has their own
json schema file.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 11 2021, 3:32 AM
Harbormaster failed remote builds in B27166: Diff 33221!
catherinewu added inline comments.
helm/dagster/charts/dagster-user-deployments/values.yaml
4 ↗(On Diff #33236)

should we have more description about when this subchart should be used? also im assuming the usage guide will be added to the k8s deployment guides?

8 ↗(On Diff #33236)

do we need enableSubchart to be set here and in helm/dagster/values.yaml?

helm/dagster/schema/schema/charts/dagster_user_deployments/values.py
12

userDeployments for consistency?

This revision now requires changes to proceed.Mar 16 2021, 4:34 AM

@catherinewu I removed enabled and enableSubchart in the subchart. Those two toggles should only be used by the umbrella chart to determine whether to render the subchart

helm/dagster/schema/schema/charts/dagster_user_deployments/values.py
12

deployments is consistent with the previous naming - should we rename it?

This revision is now accepted and ready to land.Mar 17 2021, 6:12 PM
This revision was automatically updated to reflect the committed changes.