Page MenuHomePhabricator

Add message for STEP_SUCCESS event type
ClosedPublic

Authored by sashank on Jul 24 2019, 10:26 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:c12f711fd43a: Add message for STEP_SUCCESS event type
Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Jul 24 2019, 10:26 PM
sashank updated this revision to Diff 3143.Jul 24 2019, 10:41 PM

snapshot

max added a subscriber: max.Jul 24 2019, 10:44 PM
max added inline comments.
python_modules/dagster/dagster/core/events/__init__.py
312

it would be nice to format this timestamp in a slightly more humane way:

533ms
2.1s
4m52s
34m12s
1h4m

sashank updated this revision to Diff 3144.Jul 24 2019, 10:46 PM

snapshot

sashank updated this revision to Diff 3148.Jul 24 2019, 11:03 PM

s n a p s h o t s

sashank updated this revision to Diff 3153.Jul 24 2019, 11:35 PM

Make ms duration human readable

max requested changes to this revision.Jul 24 2019, 11:42 PM
max added inline comments.
python_modules/dagster/dagster/utils/timing.py
7 ↗(On Diff #3153)

needs tests

This revision now requires changes to proceed.Jul 24 2019, 11:42 PM
sashank updated this revision to Diff 3155.Jul 24 2019, 11:49 PM

Remove timing

max accepted this revision.Jul 24 2019, 11:49 PM
This revision is now accepted and ready to land.Jul 24 2019, 11:49 PM