Page MenuHomeElementl
Differential D6865

Housekeeping and code coverage
ClosedPublic
Actions

Authored by • max on Mar 9 2021, 11:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 16, 4:53 AM
Unknown Object (File)
Tue, Aug 16, 4:52 AM
Unknown Object (File)
Mon, Aug 15, 7:37 AM
Unknown Object (File)
Thu, Aug 11, 8:34 PM
Unknown Object (File)
Thu, Aug 11, 8:33 PM
Unknown Object (File)
Thu, Aug 11, 8:32 PM
Unknown Object (File)
Thu, Aug 11, 8:31 PM
Unknown Object (File)
Thu, Aug 11, 8:30 PM
View All 46 Files
Subscribers
None

Details

Reviewers
alangenfeld
• prha
Commits
R1:8d5dc63795f2: Housekeeping and code coverage
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Mar 9 2021, 11:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2021, 12:18 AM
Harbormaster failed remote builds in B27096: Diff 33130!
• max updated this revision to Diff 33137.Mar 10 2021, 12:22 AM

lint

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2021, 12:41 AM
Harbormaster failed remote builds in B27101: Diff 33137!
• max updated this revision to Diff 33174.Mar 10 2021, 4:15 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2021, 4:34 PM
Harbormaster failed remote builds in B27125: Diff 33174!
• max updated this revision to Diff 34477.Mar 29 2021, 5:07 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2021, 6:14 PM
Harbormaster failed remote builds in B28130: Diff 34477!
• max updated this revision to Diff 38404.May 25 2021, 11:09 PM

rebase

• max updated this revision to Diff 38414.May 25 2021, 11:29 PM

rebase

Harbormaster failed remote builds in B31216: Diff 38404!May 25 2021, 11:30 PM
Harbormaster completed remote builds in B31223: Diff 38414.May 25 2021, 11:53 PM
• max requested review of this revision.May 25 2021, 11:53 PM
• prha accepted this revision.May 26 2021, 3:43 PM

thankyou

This revision is now accepted and ready to land.May 26 2021, 3:43 PM
Closed by commit R1:8d5dc63795f2: Housekeeping and code coverage (authored by • max). · Explain WhyMay 26 2021, 4:55 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:8d5dc63795f2: Housekeeping and code coverage.
alangenfeld added a comment.May 26 2021, 4:57 PM

thanks!

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
5 lines
dagster_tests/
core_tests/
definitions_tests/
89 lines
dynamic_tests/
graph_tests/
hook_tests/
host_representation_tests/
instance_tests/

Diff 38463

View Options

python_modules/dagster/dagster/core/definitions/composition.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_composition.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/__init__.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/graph_tests/__init__.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/hook_tests/__init__.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/__init__.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/instance_tests/__init__.py

Loading...