Page MenuHomeElementl

Misc small tweaks to the asset root page
ClosedPublic

Authored by bengotow on Mar 8 2021, 5:47 PM.

Details

Summary
  • When multiple materializations exist for the same partition, always use the most recent that contains the metadata entry as that entry's value.
  • Show the step that produced the asset in a new one-line format (Latest Source: step_name in run runid of pipeline_name: mode @ snapshot)
  • Show small (<1000 charater) markdown and JSON values inline in the top section
  • Feature flag the breadcrumb-style title to the new asset catalog design

Screen Shot 2021-03-08 at 11.44.46 AM.png (1×1 px, 501 KB)

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bengotow added a reviewer: sandyryza.
bengotow edited the summary of this revision. (Show Details)

Feature flag the breadcrumb-style title to the new asset catalog design

bengotow added a reviewer: prha.
prha added inline comments.
js_modules/dagit/src/pipelines/PipelineReference.tsx
34–39 ↗(On Diff #32985)

terse format is nice, but having hashes for both snapshot and run make it feel cluttered... wonder if we can do more visually to indicate the differerence (icon, tooltip, etc?)

This revision is now accepted and ready to land.Mar 8 2021, 6:22 PM

This looks great.

A couple thoughts:

  • Could we link the step name to the step logs in the same way we do from the partitions page?
  • I'm not sure if I can articulate it well, but I don't love the word "source". Maybe because I associate source with a data source vs. a pipeline. Maybe replace with something like "Materialized by" or "Materialized from"?

Thanks folks! I'll tinker with this a bit more, I agree that sentence is a bit of a mouthful, the icons could help a lot.

I think we could say "Latest materialization from" maybe? Trying to keep "Latest" in there because it's a nice reminder that the materialization may not always be emitted from the same place.

"Latest materialization from" sounds reasonable to me.

Update presentation of "latest materialization from"

This revision is now accepted and ready to land.Mar 15 2021, 4:10 PM

Talked with sandy + dish and revised the presentation to look like this:

image.png (301×631 px, 37 KB)

This revision was automatically updated to reflect the committed changes.