Page MenuHomeElementl

Add snapshotId support to PiplineAndMode, display mode in more places
ClosedPublic

Authored by bengotow on Mar 8 2021, 5:03 PM.

Details

Summary

This diff refactors PiplineAndMode a bit so that you can optionally include the snapshotId, which is rendered after the pipeline name and before the mode (per discussion with Alex).

I also expanded the places PipelineAndMode is used so that the mode is visible in a few more places, and renamed it PipelineReference which I think makes more sense now that renders the full specification of name+snapshot+mode with linking.

I also gave the component more ownership of the link generation, because I think asking people to provide a RepoAddress or explicitly type "repo-unknown" will encourage use of the RepoAddress whenever it's available, and also make sure you have to explicitly opt-out of linking anywhere the pipleine is referenced.

image.png (1×1 px, 435 KB)

image.png (1×1 px, 464 KB)

image.png (1×1 px, 287 KB)

image.png (1×1 px, 296 KB)

Test Plan

Review screenshots

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

makeitso

js_modules/dagit/src/pipelines/PipelineReference.tsx
12

This enum makes me a little itchy, but we can go ahead with it now and refine it later.

This revision is now accepted and ready to land.Mar 9 2021, 11:20 PM