Page MenuHomeElementl

Enable grpc health check probe by default
Needs ReviewPublic

Authored by johann on Mar 5 2021, 6:58 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Test Plan

helm install --dry-run

Integration

Diff Detail

Repository
R1 dagster
Branch
grpc-probe (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

johann requested review of this revision.Mar 5 2021, 7:17 PM
johann added inline comments.
helm/dagster/templates/deployment-user.yaml
82

@rexledesma the only issue with this is that you can't set the probe to {} for one deployment, since it gets overriden. Maybe we can do something with hasKey?

113

todo

helm/dagster/templates/deployment-user.yaml
82

livenessProbe should be of the form:

livenessProbe:
  enabled: bool
  probe: Optional[kubernetes.LivenessProbe]

We can put some comment mentioning that enabled causes override behavior for an individual deployment.