Page MenuHomePhabricator

[dagit] lint adjustments
ClosedPublic

Authored by alangenfeld on Jul 23 2019, 7:31 PM.

Details

Test Plan

yarn lint, yarn test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jul 23 2019, 7:31 PM
alangenfeld updated this revision to Diff 3178.Jul 25 2019, 4:16 PM

update snapshots

alangenfeld added inline comments.Jul 25 2019, 4:18 PM
js_modules/dagit/src/plan/DisplayEvent.tsx
97โ€“103

removing this unused thing caused the generated class names to change (which seems bizarre) so i had to redo snapshots

bengotow accepted this revision.Jul 25 2019, 4:47 PM

Looks good to me! Definitely odd that the autogenerated classnames changed but that seems consistent with my experience ๐Ÿ˜…

This revision is now accepted and ready to land.Jul 25 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.