Page MenuHomePhabricator

[dagit] fix types list error
ClosedPublic

Authored by alangenfeld on Jul 23 2019, 6:42 PM.

Details

Reviewers
bengotow
Group Reviewers
Restricted Project
Commits
R1:6014a06ef74a: [dagit] fix types list error
Summary
  • Update the loading component
    • handle errors when data is empty
    • print errors to console and render a placeholder to prevent taking down the entire app
  • fix the issue where we couldnt normalize data back to store since we didnt query name for pipeline
Test Plan

implemented the error improvements first to verify they worked then fixed the issue

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jul 23 2019, 6:42 PM

the error apollo link dingus seems to not fire on apollo internal errors like this one

bengotow accepted this revision.Jul 23 2019, 6:54 PM

Looks good to me!

js_modules/dagit/src/Loading.tsx
27

Yikes... thanks for handling this!

This revision is now accepted and ready to land.Jul 23 2019, 6:54 PM
This revision was automatically updated to reflect the committed changes.