Page MenuHomeElementl

Retries -> RetryMode & RetryState
ClosedPublic

Authored by alangenfeld on Mar 4 2021, 3:54 AM.

Details

Summary

When Retries was first added it was pretty clear it was a weird mix of mode and state which is why it was left with its weird name.

Well now is the time to correct that. This diff splits the two properties in to separate entities and factors things accordingly.

I have added KnownExecutionState as a wrapper/container for snapshotting RetryState since a subsequent diff will add the dynamic output resolution state next to it.

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 4:19 AM
Harbormaster failed remote builds in B26835: Diff 32798!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 9:13 PM
Harbormaster failed remote builds in B26871: Diff 32846!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 9:57 PM
Harbormaster failed remote builds in B26875: Diff 32851!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 10:55 PM
Harbormaster failed remote builds in B26885: Diff 32861!

This all makes sense to me

python_modules/dagster/dagster/core/execution/plan/state.py
10

Add some comments here about how this is threaded through and what type of data this should contain?

This revision is now accepted and ready to land.Mar 8 2021, 5:36 PM

rebase, changes.md entry and comment

This revision was automatically updated to reflect the committed changes.