Differential D6782 Authored by alangenfeld on Mar 4 2021, 3:54 AM.
Details
Summary When Retries was first added it was pretty clear it was a weird mix of mode and state which is why it was left with its weird name. Well now is the time to correct that. This diff splits the two properties in to separate entities and factors things accordingly. I have added KnownExecutionState as a wrapper/container for snapshotting RetryState since a subsequent diff will add the dynamic output resolution state next to it. Test Plan integration
Diff Detail
Event TimelineHarbormaster failed remote builds in B26834: Diff 32797!Mar 4 2021, 4:09 AM2021-03-04 04:09:26 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 4:19 AM2021-03-04 04:19:09 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 9:13 PM2021-03-04 21:13:57 (UTC+0) alangenfeld edited the test plan for this revision. (Show Details)Mar 4 2021, 9:14 PM2021-03-04 21:14:35 (UTC+0) Harbormaster failed remote builds in B26874: Diff 32850!Mar 4 2021, 9:49 PM2021-03-04 21:49:12 (UTC+0) alangenfeld edited the summary of this revision. (Show Details)Mar 4 2021, 9:56 PM2021-03-04 21:56:51 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 9:57 PM2021-03-04 21:57:53 (UTC+0) Harbormaster failed remote builds in B26884: Diff 32860!Mar 4 2021, 10:46 PM2021-03-04 22:46:43 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2021, 10:55 PM2021-03-04 22:55:14 (UTC+0) Comment Actions This all makes sense to me
This revision is now accepted and ready to land.Mar 8 2021, 5:36 PM2021-03-08 17:36:40 (UTC+0) Harbormaster completed remote builds in B27071: Diff 33098.Mar 9 2021, 9:58 PM2021-03-09 21:58:49 (UTC+0) Closed by commit R1:2e79f422eed3: Retries -> RetryMode & RetryState (authored by alangenfeld). · Explain WhyMar 9 2021, 10:26 PM2021-03-09 22:26:16 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33111 python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_executor_definition.pyLoading... python_modules/dagster/dagster_tests/core_tests/execution_plan_tests/test_execution_plan.pyLoading... | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||