Page MenuHomePhabricator

[arc] setup black and eslint linters
ClosedPublic

Authored by alangenfeld on Jul 23 2019, 5:28 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:6b5082f6ad69: [arc] setup black and eslint linters
Summary

use pinterests implementations for black and eslint linters https://github.com/pinterest/arcanist-linters

people will need to run git clone https://github.com/pinterest/arcanist-linters.git pinterest-linters next to their arcanist installs

depends on D674

Test Plan

manually lint a few files

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jul 23 2019, 5:28 PM
alangenfeld edited the summary of this revision. (Show Details)Jul 23 2019, 5:33 PM
max added a subscriber: max.Jul 23 2019, 7:41 PM

Do we have a doc somewhere explaining the steps people should take to set up arcanist?

max accepted this revision.Jul 24 2019, 6:02 PM

very into this

This revision is now accepted and ready to land.Jul 24 2019, 6:02 PM
This revision was automatically updated to reflect the committed changes.