Page MenuHomeElementl

Allow config for custom instance classes
ClosedPublic

Authored by max on Mar 3 2021, 7:50 PM.

Details

Summary

This is just a raw dict, it isn't validated against a config type -- we might want to do that, will push DagsterInstance closer to ConfigurableClass.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2021, 8:29 PM
Harbormaster failed remote builds in B26766: Diff 32710!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2021, 8:59 PM
Harbormaster failed remote builds in B26776: Diff 32722!
max requested review of this revision.Mar 3 2021, 9:28 PM
This comment was removed by dgibson.
python_modules/dagster/dagster/core/test_utils.py
332 ↗(On Diff #32729)

this is from the previous diff i think

@alangenfeld any objections

only concerns around the complexity that future us will deal with when we figure out a better way to model what is currently the instance. This seems marginal - add a test that encodes the intended use case this supports

python_modules/dagster/dagster/core/instance/__init__.py
393–400

leave some comments at least

This revision is now accepted and ready to land.Mar 4 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.