Page MenuHomeElementl

Factor instance weakref machinery into a mixin
ClosedPublic

Authored by max on Mar 3 2021, 5:55 PM.

Details

Summary

This also provides a weakref to the instance on the storages.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2021, 7:58 PM
Harbormaster failed remote builds in B26757: Diff 32701!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2021, 8:25 PM
Harbormaster failed remote builds in B26764: Diff 32708!
max requested review of this revision.Mar 3 2021, 8:54 PM

I think this is a breaking change for custom run launchers? So you should probably wait to land until we branch, and add a note as a small breaking change for 0.11.0 (there will probably be at least one more)

This revision is now accepted and ready to land.Mar 4 2021, 5:06 PM

add deprecation warning

This revision was automatically updated to reflect the committed changes.