Page MenuHomeElementl

RFC: Move handle refresh time management code from individual daemons into RepositoryLocationHandleManager
AbandonedPublic

Authored by dgibson on Mar 3 2021, 4:21 PM.

Details

Summary

This adds a min_time parameter to both RepositoryLocationHandleManager and GrpcServerRegistry. Instead of the sensor daemon being responsible for reloading its handles every 60 seconds, we could pass in the min time of (60 seconds ago) as the creation time and rely

The run queue daemon has a much lower min_time to reflect the fact that we want the handle to be up to date when we launch runs (especially if you're using managed gRPC servers). (We could also set the run creation time as the min time, but getting that time currently requires querying the event log)

If this seems like a reasonable direction, I'll add some tests that specifically test the reload behavior.

Test Plan

BK (Will write more)

Diff Detail

Repository
R1 dagster
Branch
fixstackcleanup2
Lint
Lint Passed
Unit
No Test Coverage