Page MenuHomeElementl

[dagit] Move mode alongside pipeline name
ClosedPublic

Authored by dish on Mar 2 2021, 4:57 PM.

Details

Summary

Move "mode" information to be alongside pipeline name in Dagit. The [pipeline, mode] tuple seems pretty important, so it seems to make sense to show these pieces of information in the same place. It also saves us some horizontal space for our tables.

Test Plan

View Runs, Schedules, Sensors, Ticks tables in Dagit. Verify that mode is alongside pipeline name.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Open to thoughts on the style here, and thoughts on whether this is good/bad at all.

Screen Shot 2021-03-02 at 10.55.32 AM.png (376×1 px, 78 KB)

Screen Shot 2021-03-02 at 10.55.24 AM.png (484×1 px, 119 KB)

Screen Shot 2021-03-02 at 10.55.42 AM.png (636×1 px, 119 KB)

Screen Shot 2021-03-02 at 10.55.12 AM.png (794×1 px, 199 KB)

dish requested review of this revision.Mar 2 2021, 5:04 PM

Factor pipeline+mode into a reusable component, don't show mode if default.

This seems like a nice presentation - I think we've been struggling for a while to find a consistent home for "mode" that doesn't make it look like a tag. I like having the <PipelineAndMode> component to wrap up the UI - I wonder if we could push the href generation down into that component in any way? I'm not sure how easy it'd be to retrieve repoAddress within the component...

This revision is now accepted and ready to land.Mar 4 2021, 8:16 PM

I'm not sure how easy it'd be to retrieve repoAddress within the component...

We can't reliably retrieve the repoAddress based on the pipeline name, since the workspace could be empty or the pipeline name could be reused in multiple repos within the active workspace. We could kinda sorta do it, but it would introduce uncertainty -- for now at least, we should have the necessary context within the parent.

This revision was automatically updated to reflect the committed changes.