Page MenuHomeElementl

add support for back-compatting snapshots when introducing new keys to a serializable namedtuple
ClosedPublic

Authored by dgibson on Mar 2 2021, 4:16 PM.

Details

Summary

This can be used to add new keys to origins without changing the origin ID (as least when the new field is None). Will use this to add use_ssl field to the gRPC origin without breaking all existing gRPC schedules and sensors.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 4:32 PM
Harbormaster failed remote builds in B26667: Diff 32593!
dgibson retitled this revision from add support for back-compatting snapshots when introducing new keys to a to add support for back-compatting snapshots when introducing new keys to a serializable namedtuple.

up

alangenfeld added inline comments.
python_modules/dagster/dagster/serdes/serdes.py
115–124

leave a comment here in code for why this exists

This revision is now accepted and ready to land.Mar 2 2021, 7:46 PM
This revision was landed with ongoing or failed builds.Mar 2 2021, 8:36 PM
This revision was automatically updated to reflect the committed changes.