Page MenuHomeElementl

[4/n init_resources] init_resources context manager
ClosedPublic

Authored by cdecarolis on Mar 2 2021, 4:01 PM.

Details

Summary

This diff adds a standalone context manager for initializing resources.

Test Plan

test_resource_initialization.py

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 4:18 PM
Harbormaster failed remote builds in B26665: Diff 32590!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 8:25 PM
Harbormaster failed remote builds in B26689: Diff 32618!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 8:52 PM
Harbormaster failed remote builds in B26691: Diff 32622!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 9:13 PM
Harbormaster failed remote builds in B26694: Diff 32626!
python_modules/dagster/dagster_tests/core_tests/test_composites.py
1 ↗(On Diff #32630)

this somehow got picked up in the refactor. Getting rid of.

Get rid of refactor artifact

either drop the recorder bit for now or put it under test with a real use case

python_modules/dagster/dagster/core/execution/resolve_versions.py
169–185

looks like were not doing anything with this

174–175

?

This revision is now accepted and ready to land.Mar 3 2021, 8:33 PM
python_modules/dagster/dagster/core/execution/resolve_versions.py
169–185

correct

174–175

subselecting which resources to init

Addressing comments + propogating changes