Page MenuHomeElementl

[dagster-mysql] Adding experimental warnings to dagster-mysql
ClosedPublic

Authored by sidkmenon on Mar 2 2021, 3:25 AM.

Details

Summary

Since dagster-mysql is still in the early days of being added into master I figured it'd be a smart idea to add an experimental warning to it.

Test Plan

N/A

Diff Detail

Repository
R1 dagster
Branch
mysql-perf (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Mar 2 2021, 6:01 PM
rexledesma added inline comments.
python_modules/libraries/dagster-mysql/dagster_mysql/event_log/event_log.py
48

let's use the @experimental decorator instead, experimental_class_warning doesn't seem to be used often and we can probably remove it

This revision now requires changes to proceed.Mar 2 2021, 7:14 PM

Using @experimental warning instead

approving to unblock!

python_modules/libraries/dagster-mysql/dagster_mysql/run_storage/run_storage.py
19–20

this should be on the class instead, otherwise the experimental error will be unhelpful (it will display __init__ rather than the class name)

python_modules/libraries/dagster-mysql/dagster_mysql/schedule_storage/schedule_storage.py
37

same here

This revision is now accepted and ready to land.Mar 3 2021, 7:03 PM