Differential D6729

fix post definition solid tags
ClosedPublic
Actions

Authored by alangenfeld on Mar 1 2021, 11:49 PM.

Tags

None

Subscribers

None

Details

Reviewers

rexledesma
dgibson
catherinewu

Commits

R1:a86e9373e86c: fix post definition solid tags

Summary

accident in D6155

Test Plan

added test

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alangenfeld created this revision.Mar 1 2021, 11:49 PM

Harbormaster completed remote builds in B26641: Diff 32559.Mar 2 2021, 12:08 AM

alangenfeld requested review of this revision.Mar 2 2021, 12:08 AM

dgibson accepted this revision.Mar 2 2021, 2:22 AM

dgibson added inline comments.

python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py
87–105	seems like a good test but little bit surprised this is only tested in dagster_k8s? technically any solid can have a tag applied in the pipeline right? Worth having something in core?

This revision is now accepted and ready to land.Mar 2 2021, 2:22 AM

alangenfeld added inline comments.Mar 2 2021, 3:58 PM

python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py
87–105	word - I will add another test in core before i land here

core test for tags

Harbormaster failed remote builds in B26680: Diff 32607!Mar 2 2021, 7:12 PM

This revision was landed with ongoing or failed builds.Mar 2 2021, 7:59 PM

Closed by commit R1:a86e9373e86c: fix post definition solid tags (authored by alangenfeld). · Explain Why

This revision was automatically updated to reflect the committed changes.

alangenfeld added a commit: R1:a86e9373e86c: fix post definition solid tags.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

execution/

plan/

5 lines

dagster_tests/

core_tests/

definitions_tests/

test_composition.py

15 lines

libraries/

dagster-k8s/

dagster_k8s_tests/

unit_tests/

test_resource_tags.py

35 lines

Diff 32617

python_modules/dagster/dagster/core/execution/plan/plan.py

Loading...

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_composition.py

Loading...

python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py

Loading...