Page MenuHomeElementl

fix post definition solid tags
ClosedPublic

Authored by alangenfeld on Mar 1 2021, 11:49 PM.

Details

Summary

accident in D6155

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson added inline comments.
python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py
87–105

seems like a good test but little bit surprised this is only tested in dagster_k8s? technically any solid can have a tag applied in the pipeline right? Worth having something in core?

This revision is now accepted and ready to land.Mar 2 2021, 2:22 AM
python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py
87–105

word - I will add another test in core before i land here

This revision was landed with ongoing or failed builds.Mar 2 2021, 7:59 PM
This revision was automatically updated to reflect the committed changes.