Page MenuHomeElementl

Reconstructable from file pointing to workspace yaml
AbandonedPublic

Authored by cdecarolis on Mar 1 2021, 10:08 PM.

Details

Reviewers
alangenfeld
Summary

This diff adds a static method to workspace that returns a reconstructable pipeline given the path to a workspace.yaml and a pipeline_name.

This diff still requires some more tests, particularly for the multi-repo case.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Branch
default_reconstructable
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 10:26 PM
Harbormaster failed remote builds in B26635: Diff 32553!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 11:21 PM
Harbormaster failed remote builds in B26637: Diff 32555!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 2:01 PM
Harbormaster failed remote builds in B26658: Diff 32583!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 4:24 PM
Harbormaster failed remote builds in B26666: Diff 32591!
alangenfeld added inline comments.
python_modules/dagster/dagster/cli/workspace/workspace.py
152

one thing we will have to figure out is what arguments we accept here
pipeline_def
pipeline_name
repo name, pipeline name
repo location name, repo name, pipeline name
etc

168–241

these bits are odd to exist this way - i am guessing we will move stuff on to Workspace but well see

This revision now requires changes to proceed.Mar 3 2021, 8:30 PM
python_modules/dagster/dagster/cli/workspace/workspace.py
168–241

yea this is the part of stuff that exists in the grpc portion of the repo that I feel like we need to pull in