Page MenuHomeElementl

[dagit] Localize elapsed time and logs timestamps
ClosedPublic

Authored by dish on Mar 1 2021, 8:35 PM.

Details

Summary

Localize elapsed time and log timestamps in Dagit. Ideally this should improve things like rendering commas instead of decimal points for European users, etc. See screenshots.

Test Plan

Switch to German, Hungarian. Verify that commas are used for strings like 2.331s on elapsed time (2,331s) and the milliseconds on log rows (09:22:28,058).

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Mar 1 2021, 8:42 PM

Oh this is super cool - nice that we don't need moment for this sort of thing these days.

This revision is now accepted and ready to land.Mar 4 2021, 8:14 PM