Page MenuHomeElementl

Don't keep the managed grpc server process running if there's an error while loading user code
ClosedPublic

Authored by dgibson on Feb 27 2021, 11:31 PM.

Details

Summary

We originally added this lazy-load-user-code parameter because it was the only way to get error information surfaced in dagit. Now our loading path is better set up to handle errors (and surface them), so there's no need for this parameter, we can let the process die right away and surface the error in dagit (rather than waiting for the list_repositories error to fail).

Test Plan

BK, load dagit pointing at a file with a syntax error, syntax error still surfaced in dagit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2021, 11:55 PM
Harbormaster failed remote builds in B26597: Diff 32501!
dgibson retitled this revision from Don't keep the grpc server process to Don't keep the managed grpc server process running if there's an error while loading user code.Mar 2 2021, 1:42 AM
dgibson added reviewers: alangenfeld, sashank.
This revision is now accepted and ready to land.Mar 3 2021, 7:39 PM