Page MenuHomePhabricator

Handle composites correctly in Airflow
ClosedPublic

Authored by nate on Jul 22 2019, 10:35 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:dde9b758a533: Handle composites correctly in Airflow
Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Jul 22 2019, 10:35 PM
nate added a comment.Jul 22 2019, 10:38 PM

Looks like this now

nate added a reviewer: Restricted Project.Jul 22 2019, 10:42 PM
alangenfeld added inline comments.
python_modules/dagster-airflow/dagster_airflow/compile.py
17

post D671 i think its always 1:1 solid to execution step

I think most of this code might actually stay the same since we still need sorting and deps building but maybe renaming is in order

max accepted this revision.Jul 23 2019, 7:40 PM
This revision is now accepted and ready to land.Jul 23 2019, 7:40 PM
nate planned changes to this revision.Jul 23 2019, 11:26 PM

ok, I'm going to hold onto this one until @alangenfeld merges D671 to verify it after rebasing on top of that change

nate updated this revision to Diff 3145.Jul 24 2019, 10:46 PM

rebase

This revision is now accepted and ready to land.Jul 24 2019, 10:46 PM
This revision was automatically updated to reflect the committed changes.